This repository was archived by the owner on Mar 18, 2024. It is now read-only.
Add pip as an explicit dependency#94
Open
spencermathews wants to merge 1 commit intoholoviz-topics:mainfrom
Open
Add pip as an explicit dependency#94spencermathews wants to merge 1 commit intoholoviz-topics:mainfrom
spencermathews wants to merge 1 commit intoholoviz-topics:mainfrom
Conversation
Author
|
What's up with those checks anyway? And why should they fail due to such an innocuous change? |
Collaborator
|
It's presumably due to one of our dependencies having released a new and slightly incompatible version; nothing to do with your change. Any new PR opened now will probably show the same problem... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating the earthml conda enviroment according to the installation instructions leads to a warning related to pip:
Including
pipin the environment prevents this warning, avoids any ambiguity surrounding pip dependencies, and conforms to the best practices as I interpret them.