Skip to content
This repository was archived by the owner on Oct 1, 2021. It is now read-only.

Added a Samsung Printer discoverable#174

Merged
balloob merged 3 commits intohome-assistant-libs:masterfrom
nielstron:master
Feb 20, 2018
Merged

Added a Samsung Printer discoverable#174
balloob merged 3 commits intohome-assistant-libs:masterfrom
nielstron:master

Conversation

@nielstron
Copy link
Copy Markdown
Contributor

No description provided.

@rytilahti
Copy link
Copy Markdown
Contributor

Would it make more sense to have a generic printer discovery?

@nielstron
Copy link
Copy Markdown
Contributor Author

I implemented this because Samsung Printers do provide a special SyncThru webservice, that can be fetched via json/ pysyncthru. Thought being more specific wouldn't hurt.

@balloob
Copy link
Copy Markdown
Contributor

balloob commented Feb 20, 2018

I think that more generic wouldn't make much sense.

Can you rename the file samsung_printer ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants