Plex component doesn't remove clients/status.

[riemers]

Home Assistant release (hass --version):
0.56.1

Python release (python3 --version):
3.4.2

Component/platform:
plex

Description of problem:
When a player starts it gets the correct picture/status. When you pause it, it will work too. But when you stop/remove it and it is no longer visible in plex server the client/picture stays in Hass. If you have multiple clients/movies watched this can stack up. At some point i had 9 movies/series playing while there was only 1 in plex. See also thread https://community.home-assistant.io/t/plexdevices-custom-media-player-component/11246/275 not much activity, but more people complaining about the issue. Alternative is https://community.home-assistant.io/t/status-of-a-plex-client-useful-to-trigger-automation/18540 but this is not in Hass itself.

Expected:
I would like to see plex updated only showing the clients that are active/paused (but not stopped/off), sounds like something simple (but don't pin me on that) @ryanm101 was busy with some updates, tagging him here to as per his request so he can take a look too.

[ryanm101]

I'll look at this along side my refactor

[ryanm101]

#9988 has now been merged if you want to try running the dev branch against your config

[ryanm101]

please check 0.61 when released

[riemers]

I will for sure, thanks for the work!

[riemers]

Sensor is working, media player looks working but i cannot use the include_non_clients: true or i will get errors:

2018-01-16 21:20:45 ERROR (MainThread) [homeassistant.components.media_player] Error while setting up platform plex
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_component.py", line 171, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 400, in wait_for
    return fut.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/media_player/plex.py", line 87, in setup_platform
    hass, config, add_devices_callback
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/media_player/plex.py", line 205, in setup_plexserver
    update_devices()
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/util/__init__.py", line 306, in wrapper
    result = method(*args, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/util/__init__.py", line 306, in wrapper
    result = method(*args, **kwargs)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/media_player/plex.py", line 172, in update_devices
    update_sessions)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/media_player/plex.py", line 293, in __init__
    self.refresh(device, session)
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/media_player/plex.py", line 359, in refresh
    if self._device.machineIdentifier is not None and \
AttributeError: 'NoneType' object has no attribute 'machineIdentifier'

This problem was also found on the forum https://community.home-assistant.io/t/plex-error-error-doing-job-future-exception-was-never-retrieved/33396/3 and an older ticket which had no feedback #10450

[ryanm101]

This is seperate from your orig issue can you please create a new ticket and i'll try and take a look. I dont use this feature though so it wont be quick :)

[donkawechico]

I'm seeing the same thing as @riemers. Setting include_non_clients: false removed the error from my logs.

[riemers]

@donkawechico but do you see any clients then? i have 0 clients when i don't use that option since many of my devices are just plex on samsung tv's. If you do, you could at least test the outstanding bug in this ticket, as i cannot for the moment.

[ryanm101]

ok i've just looked at the code i can see where the problem likely lies BUT i've no devices that i know of that would use the option. @riemers @donkawechico could you list the devices you have that you need this option for and I'll see if i have any or alternatively I may need to push you code to try out is that ok?

[ryanm101]

Can you try my branch here and see if it fixes it:
https://github.com/ryanm101/home-assistant/tree/plex_non_client

[riemers]

I'll see if i can test it tonight, if its only the plex part i could just copy those over. Don't know how much you changed.