Broadlink SP1 & SP2 switch could not work correctly

[Yonsm]

Home Assistant release with the issue:

0.67.0.dev0

Last working Home Assistant release (if known):

0.66.1

Operating environment (Hass.io/Docker/Windows/etc.):

Hassibian

Component/platform:

https://www.home-assistant.io/components/switch.broadlink/

Description of problem:

BroadlinkSP1Switch & BroadlinkSP2Switch could not work correctly.

class BroadlinkSP1Switch(BroadlinkRMSwitch):
...
super().init(friendly_name, device, None, None) # Case an error (missing one param)

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

switch:
  - platform: broadlink
    host: 192.168.1.20
    mac: 34:EA:34:B8:36:AC
    friendly_name: Outlet
    type: spmini2

Traceback (if applicable):

Additional information:

[Pho7ography]

Home Assistant release with the issue:

0.67.0

Last working Home Assistant release (if known):

0.66.1

Operating environment (Hass.io/Docker/Windows/etc.):

Hassibian

Component/platform:

https://www.home-assistant.io/components/switch.broadlink/

Description of problem:

Broadlink MP1Switch, SP2 & SP3 Switch could not work correctly.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
Sat Apr 14 2018 15:10:51 GMT+0100 (WEST)

Error while setting up platform broadlink
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 82, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/switch/broadlink.py", line 165, in setup_platform
    switches = [BroadlinkSP2Switch(friendly_name, broadlink_device)]
  File "/usr/lib/python3.6/site-packages/homeassistant/components/switch/broadlink.py", line 260, in __init__
    super().__init__(friendly_name, device, None, None)
TypeError: __init__() missing 1 required positional argument: 'command_off'

Additional information:

[MartinHjelmare]

This broke due to this PR:
#13642

CC @timmo001 @Danielhiversen

[Danielhiversen]

@Yonsm @Pho7ography : Could you try this fx:
https://github.com/home-assistant/home-assistant/compare/dev...issue%2313799?quick_pull=1

[Nescafemix]

That problem affects the SP3 too. I have the same problem with that.

[Danielhiversen]

@Nescafemix Have you tried this fix: https://github.com/home-assistant/home-assistant/compare/dev...issue%2313799?quick_pull=1 ??

[Nescafemix]

@Danielhiversen I didn't try that fix, but i thought it was not going to fix the problem, cause my error is being done over BroadlinkSP2Switch and this PR don't change nothing on it (it does on BroadlinkSP1Switch). I've just seen BroadlinkSP2Switch is created with an instance of BroadlinkSP1Switch so, maybe it could do the fix.

I don't know how to try changes done on that PR. I'm executing an instance of Hassio. Where could I change the necessary file?

Here you can find my error:

2018-04-14 20:50:35 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform climate.broadlink: Could not install all requirements.
2018-04-14 20:50:55 ERROR (MainThread) [homeassistant.components.switch] Error while setting up platform broadlink
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 82, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/switch/broadlink.py", line 165, in setup_platform
    switches = [BroadlinkSP2Switch(friendly_name, broadlink_device)]
  File "/usr/lib/python3.6/site-packages/homeassistant/components/switch/broadlink.py", line 260, in __init__
    super().__init__(friendly_name, device, None, None)
TypeError: __init__() missing 1 required positional argument: 'command_off'

my configuration:

switch:
  - platform: broadlink
    host: 192.168.1.145
    mac: '34:ea:34:91:32:09'
    type: sp3
    friendly_name: 'Lampara de pie - Salón'

[MBulatnikov]

@Danielhiversen Hi,
I was try. SP3 showed on GUI, but if try switch do nothing. RM Pro don't show at all.
In log:

Update for switch.Heater fails
Traceback (most recent call last):
  File "/srv/homeassistant_3.6/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 204, in async_update_ha_state
    yield from self.async_device_update()
  File "/srv/homeassistant_3.6/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 327, in async_device_update
    yield from self.hass.async_add_job(self.update)
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant_3.6/lib/python3.6/site-packages/homeassistant/components/switch/broadlink.py", line 293, in update
    self._update()
  File "/srv/homeassistant_3.6/lib/python3.6/site-packages/homeassistant/components/switch/broadlink.py", line 298, in _update
    state = self._device.check_power()
  File "/srv/homeassistant_3.6/lib/python3.6/site-packages/broadlink/__init__.py", line 418, in check_power
    if ord(payload[0x4]) == 1 or ord(payload[0x4]) == 3:
TypeError: ord() expected string of length 1, but int found

My config:

#Broadlink RM Pro IR/RF Remote Controller
switch:
  - platform: broadlink
    host: 192.168.XXX.XXX
    mac: 34:EA:XX:XX:XX:XX
    type: rm_pro_phicomm
    switches:
      airconditioner:
        friendly_name: "Air Conditioner"
        command_on: 'JgBoARIAAkhhAAEmDxEQMRAREBAQERAQEBEQEBAREDEQEBAREDIPEQ8SDzIPMhAwETEQMRAQEBEQEBAREBAQERARDxIPEQ8SDxEPEhAQEBEQEBAREBAQERAQEBEQEBAREBAQERARDxIPEQ8SDxEP$
        command_off: 'JgBoARMAAkdiAAEkEw0SLxMPEQ8PEg8RDxIPERAREi8SDhIPEi8SLxIOEy4TLxIvDzIPMhAREQ8SDxIOEw4SDhMOEg4TDhIPEg4SDhMOEg8REA8RDxIPEQ8SEQ8TDhIOEg8SDhMOEg4TDhIOEw8$

#Broadlink smart socket SP3C (SP CC)
  - platform: broadlink
    host: 192.168.XXX.XXX
    mac: 34:EA:XX:XX:XX:XX
    type: sp3
    friendly_name: 'Heater'

HASS installed in venv on Ubuntu server 16.04 LTS
HASS 0.67
Python 3.6.4

[lordneon]

@Danielhiversen

That patch fixes the error "TypeError: init() missing 1 required positional argument: 'command_off'"

However my switch is not working as expected still:

2018-04-15 09:40:00 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.Lamp fails
Traceback (most recent call last):
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity.py", line 204, in async_update_ha_state
    yield from self.async_device_update()
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity.py", line 327, in async_device_update
    yield from self.hass.async_add_job(self.update)
  File "/usr/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 304, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/components/switch/broadlink.py", line 293, in update
    self._update()
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/components/switch/broadlink.py", line 298, in _update
    state = self._device.check_power()
  File "/opt/homeassistant/lib/python3.5/site-packages/broadlink/__init__.py", line 418, in check_power
    if ord(payload[0x4]) == 1 or ord(payload[0x4]) == 3:
TypeError: ord() expected string of length 1, but int found

This is with a broadlink SP2, was working fine with previous update.

[eyalsac]

RM-Pro, SP2, MP1 and SC1 don't load al all since 0.67.
deleting all the friendly names didn't help/

[Danielhiversen]

@Nescafemix It should fixes the problem for sp2 too.

@eyalsac: Try this fix: #13906

@Gui1ty , @lordneon : That seems to be an issue in the broadlink library. So you should report the issue there.

[lordneon]

I've patched the broadlink library have have created a pull request.

Fix is here: https://github.com/mjg59/python-broadlink/pull/178/files

[clyra]

hi,

Tried both fixes but there's still something missing. I'm getting this error now:

Apr 15 11:36:41 ha hass[9771]: #33[31m2018-04-15 11:36:41 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved#033[0m
Apr 15 11:36:41 ha hass[9771]: Traceback (most recent call last):
Apr 15 11:36:41 ha hass[9771]: File "/home/usuario/hass/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 245, in _async_add_entity
Apr 15 11:36:41 ha hass[9771]: 'Invalid entity id: {}'.format(entity.entity_id))
Apr 15 11:36:41 ha hass[9771]: homeassistant.exceptions.HomeAssistantError: Invalid entity id: switch.fita cozinha#033[0m

my config:

• platform: broadlink
  host: 192.168.0.xx
  mac: '34:ea:34:xx:xx:xx'
  friendly_name: fita cozinha
  type: sp2