Roborock setup fails with construct

[rybackisback]

The problem

Logger: homeassistant.config_entries
Source: components/roborock/init.py:45
First occurred: 7:37:43 AM (8 occurrences)
Last logged: 10:49:00 AM

Error setting up entry xxxxxxxx@gmail.com for roborock
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/roborock/init.py", line 45, in async_setup_entry
network_results = await asyncio.gather(
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/util.py", line 89, in wrapped
raise e
File "/usr/local/lib/python3.11/site-packages/roborock/util.py", line 85, in wrapped
last_run_result = await func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 357, in get_networking
return await self.send_command(RoborockCommand.GET_NETWORK_INFO, return_type=NetworkInfo)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/cloud_api.py", line 165, in send_command
msg = MessageParser.build(roborock_message, local_key, False)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/protocol.py", line 342, in build
return self.con.build({"messages": [message for message in messages]}, local_key=local_key, prefixed=prefixed)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/construct/core.py", line 352, in build
self.build_stream(obj, stream, **contextkw)
File "/usr/local/lib/python3.11/site-packages/construct/core.py", line 364, in build_stream
self._build(obj, stream, context, "(building)")
File "/usr/local/lib/python3.11/site-packages/construct/core.py", line 1998, in _build
subobj = obj[sc.name] # raises KeyError
~~~^^^^^^^^^
KeyError: 'remaining'

What version of Home Assistant Core has the issue?

2023.6.0

What was the last working version of Home Assistant Core?

2023.5.4

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Roborock

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roborock/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant]

Hey there @humbertogontijo, @Lash-L, mind taking a look at this issue as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign roborock Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

---

roborock documentation
roborock source
_{^{(message by IssueLinks)}}

[Lash-L]

Does this happen multiple times on setup? i.e if you restart, does it still happen.

@humbertogontijo Any idea on this one? Seems to be an issue with construct/ the length of the package

[rybackisback]

I have tried deleting and re-installing the integration multiple times and every time I get the same error. I also tried to re-install after restarting HA and still get the same error. i also get a notification on my roborock app "your account is logged in another device. if you didnt do this yourself, please change your password."

[humbertogontijo]

@Lash-L are you able to run the integration in python 11? It could be an incompatibility to py version.
I can investigate this further once I have some time

[rybackisback]

I am not sure how to do that. If you can please provide instructions I can try.

[Lash-L]

@rybackisback He was talking to me - no worries.

@humbertogontijo I bumped my dev container to 3.11 and it worked no problems for me, but it doesn't mean that there isn't a compatibility issue.

@rybackisback

1. What vacuum do you have?
2. How do you have Home Assistant installed? What OS?
3. This only broke for you when you updated to 2023.06?

[freeDom-]

I am also using HA Supervised (using Py 3.11) and was able to install the Roborock integration successfully on 2023.06 today... What else might be the differences between our installations that mine works?

Are you using the Roborock App or the Xiami App?

[humbertogontijo]

Since I'm not having this issue I'm not sure if this will work. But here is a try to fix it Python-roborock/python-roborock@89e1f28

[A-vesalius]

@Lash-L same issue as OP

1. What vacuum do you have?
2. How do you have Home Assistant installed? What OS?
3. This only broke for you when you updated to 2023.06

1. Max s7
2. proxmox VM, HaOS 10.2
3. Yes was working fine before on 2023.05

`Logger: homeassistant.config_entries
Source: components/roborock/init.py:45
First occurred: June 7, 2023 at 4:46:29 PM (3 occurrences)
Last logged: 12:26:12 PM

Error setting up entry xxxxxxxxx@icloud.com for roborock
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/roborock/init.py", line 45, in async_setup_entry
network_results = await asyncio.gather(
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/util.py", line 89, in wrapped
raise e
File "/usr/local/lib/python3.11/site-packages/roborock/util.py", line 85, in wrapped
last_run_result = await func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 357, in get_networking
return await self.send_command(RoborockCommand.GET_NETWORK_INFO, return_type=NetworkInfo)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/cloud_api.py", line 158, in send_command
await self.validate_connection()
File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 197, in validate_connection
await self.async_connect()
File "/usr/local/lib/python3.11/site-packages/roborock/cloud_api.py", line 143, in async_connect
(_, err) = await self._async_response(CONNECT_REQUEST_ID)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/roborock/api.py", line 208, in _async_response
raise RoborockTimeout(f"id={request_id} Timeout after {QUEUE_TIMEOUT} seconds") from None
roborock.exceptions.RoborockTimeout: id=0 Timeout after 4 seconds
`

[oudoulj]

Installed the Roborock integration, typed my email then the 6-digit code I received by email.
Failed immediately with :
Retrying setup: Could not get network information about your devices

Enabled debug logging and got (on /config/logs) :

Logger: homeassistant.config_entries
Source: config_entries.py:1247
First occurred: 19:16:46 (2 occurrences)
Last logged: 19:47:02

Config entry 'xxx@yyy.com' for roborock integration not ready yet: Could not get network information about your devices; Retrying in background

I don't know what to do with that 😿
And sorry if it's a different problem than the OP's.

[freeDom-]

Installed the Roborock integration, typed my email then the 6-digit code I received by email. Failed immediately with : Retrying setup: Could not get network information about your devices

Enabled debug logging and got (on /config/logs) :

Logger: homeassistant.config_entries
Source: config_entries.py:1247
First occurred: 19:16:46 (2 occurrences)
Last logged: 19:47:02

Config entry 'xxx@yyy.com' for roborock integration not ready yet: Could not get network information about your devices; Retrying in background

I don't know what to do with that 😿 And sorry if it's a different problem than the OP's.

This is clearly a different issue - would be better to track it in a seperate issue... Could be related to network problems, but I would wait to see what someone who actually wrote the code says about it...

[rybackisback]

@rybackisback He was talking to me - no worries.

@humbertogontijo I bumped my dev container to 3.11 and it worked no problems for me, but it doesn't mean that there isn't a compatibility issue.

@rybackisback

1. What vacuum do you have?
2. How do you have Home Assistant installed? What OS?
3. This only broke for you when you updated to 2023.06?

@Lash-L

1. I have a Roborock S7
2. Home assistant supervised in Ubuntu 22.04 LTS
3. Yes was working until I updated to 2023.06

[Lash-L]

Let's see if #94281 ends up solving your problems and go from there