Skip to content

allow ios device tracker see calls to go through#13020

Merged
balloob merged 1 commit intodevfrom
device-tracker-see-service
Mar 10, 2018
Merged

allow ios device tracker see calls to go through#13020
balloob merged 1 commit intodevfrom
device-tracker-see-service

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 9, 2018

Description:

iOS sends invalid data to the device_tracker.see service. This will add some unused fields to the validation to make sure that we don't break the iOS app.

iOS code: https://github.com/home-assistant/home-assistant-iOS/blob/3876be84c217b2b43c42630b61e0259925d8795c/HomeAssistant/HAAPI.swift#L209-L215

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob force-pushed the device-tracker-see-service branch from 4bef337 to 0d75bd1 Compare March 9, 2018 21:03
@Martinvdm
Copy link
Copy Markdown

#13021

@balloob balloob merged commit a8a895a into dev Mar 10, 2018
@balloob balloob deleted the device-tracker-see-service branch March 10, 2018 03:39
@balloob balloob mentioned this pull request Mar 10, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants