Check whitelisted paths #13107#13154
Merged
balloob merged 1 commit intohome-assistant:devfrom Mar 30, 2018
Merged
Conversation
Member
|
That work not with Python3.5 A real fix if to check if the path exists and if not, it use the parent for validate like before. |
kellerza
force-pushed
the
is_allowed_path
branch
from
712f3aa to
c62a75d
Compare
kellerza
changed the title
balloob
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A follow up on #12810, which forced the path to EXIST as well.
Path.resolve(strict=False) does not require the path to exist, it will resolve as far as possible.
The oiginal code has Path.parent.resolve(strict=True), so have to enure the parent exists (and not just as far as possibe)
Related issue (if applicable): fixes #13107
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: