Fixing Tesla sensors to display km#13427
Merged
balloob merged 1 commit intohome-assistant:devfrom Mar 25, 2018
Merged
Conversation
homeassistant
added
platform: sensor.tesla
small-pr
alandtse
changed the title
smurfix
reviewed
Mar 24, 2018
Contributor
smurfix
left a comment
smurfix
left a comment
There was a problem hiding this comment.
Doesn't the same problem exist a few lines above your change, with °F vs. °C?
Contributor
Author
|
@smurfix It might. I didn't do any of the climate part. However, I just did a test and it doesn't appear like the sensor is switching to Celsius so there may be additional issues with it. |
balloob
approved these changes
Mar 25, 2018
| self._unit = LENGTH_MILES | ||
| else: | ||
| self._unit = LENGTH_KILOMETERS | ||
| self.current_value /= 0.621371 |
Member
There was a problem hiding this comment.
We have a converter for this in util.distance.py.
Merged
ghost
added
integration: tesla
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Corrects odometer and range sensors to display km
Related issue (if applicable): fixes #13263
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: