Improve detection of entity names in templates#13432
Merged
pvizeli merged 2 commits intohome-assistant:devfrom Mar 25, 2018
Merged
Improve detection of entity names in templates#13432pvizeli merged 2 commits intohome-assistant:devfrom
pvizeli merged 2 commits intohome-assistant:devfrom
Conversation
pvizeli
requested changes
Mar 25, 2018
Member
pvizeli
left a comment
There was a problem hiding this comment.
Please update the regex that he not detect this. All that was we can do on regex, should we do on regex otherwise we slow done this function and make it more cpu/memory hungry
Contributor
Author
|
I think the regex works as intended, it locates Instead, I have moved the filter to only affect the variable values that are appended. |
pvizeli
approved these changes
Mar 25, 2018
balloob
pushed a commit
that referenced
this pull request
Mar 26, 2018
* Improve detection of entity names in templates * Only test variables
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds filtering of extracted entity names, fixing an issue where variables with invalid IDs made the algorithm not fall back to MATCH_ALL.
Related issue (if applicable): fixes #13398
Example entry for
configuration.yaml(if applicable):Checklist:
tox.If the code does not interact with devices: