Skip to content

Bump songpal version, fixes lots of issues mentioned in #13022#13440

Merged
Danielhiversen merged 1 commit intohome-assistant:devfrom
rytilahti:bump_songpal
Mar 25, 2018
Merged

Bump songpal version, fixes lots of issues mentioned in #13022#13440
Danielhiversen merged 1 commit intohome-assistant:devfrom
rytilahti:bump_songpal

Conversation

@rytilahti
Copy link
Copy Markdown
Member

Description:

Related issue (if applicable): fixes #3022

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@rytilahti rytilahti requested a review from andrey-git as a code owner March 24, 2018 23:41
@Danielhiversen Danielhiversen merged commit f3ccbda into home-assistant:dev Mar 25, 2018
@rytilahti rytilahti deleted the bump_songpal branch March 25, 2018 17:11
@balloob balloob mentioned this pull request Apr 13, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants