Skip to content

Add extra check for ESSID field in case there's a wired connection#13459

Merged
balloob merged 1 commit intohome-assistant:devfrom
Zepheus:dev
Mar 26, 2018
Merged

Add extra check for ESSID field in case there's a wired connection#13459
balloob merged 1 commit intohome-assistant:devfrom
Zepheus:dev

Conversation

@Zepheus
Copy link
Copy Markdown
Contributor

@Zepheus Zepheus commented Mar 25, 2018

Description:

Unifi controller also manages non-wireless connections for which an essid field is not present. This will skip these hosts when an ssid filter is present.

Related issue: fixes #13366

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Entry for configuration.yaml :

device_tracker:
  - platform: unifi
    username: admin
    password: xxx
    host: 192.168.1.10
    verify_ssl: false
    detection_time: 120
    ssid_filter:
      - 'xxx'
    new-device-defaults:
      track_new_devices: False
      hide_if_away: False

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line over-indented for visual indent

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the backslash is redundant between brackets

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @Zepheus,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob balloob added this to the 0.66 milestone Mar 26, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 26, 2018

Thanks! 🐬

@Sinbad2000
Copy link
Copy Markdown

Thank you all :)

@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unifi Controller integration has stopped working, version 0.65.5

6 participants