Add extra check for ESSID field in case there's a wired connection#13459
Merged
balloob merged 1 commit intohome-assistant:devfrom Mar 26, 2018
Merged
Add extra check for ESSID field in case there's a wired connection#13459balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
houndci-bot
reviewed
Mar 25, 2018
There was a problem hiding this comment.
continuation line over-indented for visual indent
There was a problem hiding this comment.
the backslash is redundant between brackets
Contributor
balloob
approved these changes
Mar 26, 2018
Member
|
Thanks! 🐬 |
|
Thank you all :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Unifi controller also manages non-wireless connections for which an
essidfield is not present. This will skip these hosts when an ssid filter is present.Related issue: fixes #13366
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Entry for
configuration.yaml:Checklist:
tox. Your PR cannot be merged unless tests pass