Broadlink Switch - Use entity_id instead of friendly_name for entity_id#13642
Merged
Danielhiversen merged 1 commit intohome-assistant:devfrom Apr 6, 2018
timmo001:broadlink-use-correct-name
Merged
Broadlink Switch - Use entity_id instead of friendly_name for entity_id#13642Danielhiversen merged 1 commit intohome-assistant:devfrom timmo001:broadlink-use-correct-name
Danielhiversen merged 1 commit intohome-assistant:devfrom
timmo001:broadlink-use-correct-name
Conversation
Contributor
|
Fixes issue #11628 |
Contributor
|
Why label "docs-missing"? |
Member
|
Yes, you are right. |
Member
Author
|
See updated description. Is this what you needed? |
Member
|
👍 |
|
class BroadlinkSP1Switch(BroadlinkRMSwitch): switch:
|
Member
|
This is already merged, so please open an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The current version of this component uses the friendly_name instead of the set entity_id as set in the config. This fixes this issue. In the example, the entity_id would be 'tv_phillips' and the friendly_name 'Phillips TV Power'.
Example entry for
configuration.yaml(if applicable):Breaking Change
Users who were using this switch with the entity_id and the friendly_name as different names will need to update their automations/groups to use the entity_id instead of the friendly_name.
Checklist:
tox. Your PR cannot be merged unless tests pass