Send XY color for non-osram hue bulbs

[emlove]

Description:

It seems that Philips bulbs don't display the correct colors when given a hue/sat command. This PR restores the previous behavior of sending an XY color command for non-osram bulbs.

Original behavior for reference:

https://github.com/home-assistant/home-assistant/pull/11288/files#diff-09fd3b3fbdd20cedcad9fcf474b4aeb7L275

Related issue (if applicable): fixes #13632 fixes #13614

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

[OttoWinter]

* 255?

[OttoWinter]

Typo, seem

[emlove]

🤦‍♂️ Thanks for the catches!

[amelchio]

It seems unfair to label Philips as being incorrect.

I think it is more a matter of the Home Assistant Hue platform historically treating RGB (and by extension HS) in an unusual way by not using the bulb gamut. We are currently treating HS in the normal way and this PR will then go back to the unusual way.

However, I am not against this change as it maintains compatibility with previous versions of Home Assistant.

[emlove]

That's totally fair. My main intent is to ensure there's a good explanation in the comment to save it from being removed in a refactor.

What if the comment read like this:

The Hue/Sat API doesn't address the full color space supported by Philips bulbs, so we're first converting to XY.

[amelchio]

Hue/sat does support all possible bulb colors but they are shifted from xy and we don't know by how much because it differes for each light model. Maybe a reasonable comment would be:

We use our own conversion function for consistent xy->HS->xy translations.

However, I checked our xy conversion functions against Hue docs and I found a difference:

diff --git a/homeassistant/util/color.py b/homeassistant/util/color.py
--- a/homeassistant/util/color.py
+++ b/homeassistant/util/color.py
@@ -203,7 +203,7 @@ def color_RGB_to_xy_brightness(

     # Wide RGB D65 conversion formula
     X = R * 0.664511 + G * 0.154324 + B * 0.162028
-    Y = R * 0.313881 + G * 0.668433 + B * 0.047685
+    Y = R * 0.283881 + G * 0.668433 + B * 0.047685
     Z = R * 0.000088 + G * 0.072310 + B * 0.986039

     # Convert XYZ to xy

>>> color_xy_brightness_to_RGB(*color_RGB_to_xy_brightness(250, 250, 250))
(248, 255, 248)
>>> color_RGB_to_xy_brightness(*color_xy_brightness_to_RGB(0.5, 0.5, 128))
(0.486, 0.481, 128)

I think we should apply that diff to ensure that xy -> HS -> xy (as we end up with after this PR) actually does pass the original xy value to the bulb. That should then fix #13686 as well.

[NaffanDroo]

Is this staying in dev for the next release cycle or will there be another MR for a hotfix? Not saying it's urgent as I'm just sitting back on a 0.65 version - just curious how these things fit into the updated release cycle.

[omriasta]

Updated to the beta which should include this but the color in the UI is now worse. Changing the colors on the picker now change the bulb colors but they don't change the icon in the UI. The color is now "stuck" on the green color even when the bulbs are changing.

[amelchio]

@NaffanDroo Another hotfix is unlikely. The idea of the updated release cycle is that people like you try out the beta (it's out now) and report issues so the .0 release will have less bugs.

@omriasta you should report new bugs in new issues, though that one sounds like #13589