Adding configration to disable ip address as a requirement Fixes: #13399#13692
Merged
fabaff merged 3 commits intohome-assistant:devfrom Apr 5, 2018
Merged
Adding configration to disable ip address as a requirement Fixes: #13399#13692fabaff merged 3 commits intohome-assistant:devfrom
fabaff merged 3 commits intohome-assistant:devfrom
Conversation
Contributor
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A change to the asuswrt device tracker requires a device to have an ip address. In AP mode its possible for all of the detection methods to not provide an ip address. The new config option allows for the old (and working) functionality to be restored by no requiring an ip address. This is more specific to devices in ap mode. Default value True.
Related issue (if applicable): fixes #13399
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5117
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: