Skip to content

Adding configration to disable ip address as a requirement Fixes: #13399#13692

Merged
fabaff merged 3 commits intohome-assistant:devfrom
PlanetJ:dev
Apr 5, 2018
Merged

Adding configration to disable ip address as a requirement Fixes: #13399#13692
fabaff merged 3 commits intohome-assistant:devfrom
PlanetJ:dev

Conversation

@PlanetJ
Copy link
Copy Markdown
Contributor

@PlanetJ PlanetJ commented Apr 5, 2018

Description:

A change to the asuswrt device tracker requires a device to have an ip address. In AP mode its possible for all of the detection methods to not provide an ip address. The new config option allows for the old (and working) functionality to be restored by no requiring an ip address. This is more specific to devices in ap mode. Default value True.

Related issue (if applicable): fixes #13399

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5117

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: asuswrt
    host: YOUR_ROUTER_IP
    username: YOUR_ADMIN_USERNAME
    require_ip: False

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @PlanetJ,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff fabaff merged commit 4008bf5 into home-assistant:dev Apr 5, 2018
@balloob balloob mentioned this pull request Apr 13, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

65.5 breaks Asuswrt device_tracker (phones ) status

3 participants