Skip to content

Brightness conversion for Abode dimmers #13711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syssi merged 5 commits into from
Apr 7, 2018
Merged

Brightness conversion for Abode dimmers #13711

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f16d267
Brightness conversion for Abode dimmers
shred86 Apr 6, 2018
1d0a28a
Update abode.py
shred86 Apr 6, 2018
7ddc23b
Update abode.py
shred86 Apr 6, 2018
fac439b
Updates conversion of brightness
shred86 Apr 6, 2018
90f1981
Minor updates to conversion
shred86 Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions homeassistant/components/light/abode.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
https://home-assistant.io/components/light.abode/
"""
import logging

from math import ceil
from homeassistant.components.abode import AbodeDevice, DOMAIN as ABODE_DOMAIN
from homeassistant.components.light import (
ATTR_BRIGHTNESS, ATTR_HS_COLOR,
Expand Down Expand Up @@ -51,7 +51,9 @@ def turn_on(self, **kwargs):
*kwargs[ATTR_HS_COLOR]))

if ATTR_BRIGHTNESS in kwargs and self._device.is_dimmable:
self._device.set_level(kwargs[ATTR_BRIGHTNESS])
# Convert HASS brightness (0-255) to Abode brightness (0-99)
# If 100 is sent to Abode, response is 99 causing an error
self._device.set_level(ceil(kwargs[ATTR_BRIGHTNESS] * 99 / 255.0))
else:
self._device.switch_on()

Expand All @@ -68,7 +70,12 @@ def is_on(self):
def brightness(self):
"""Return the brightness of the light."""
if self._device.is_dimmable and self._device.has_brightness:
return self._device.brightness
brightness = int(self._device.brightness)
# Abode returns 100 during device initialization and device refresh
if brightness == 100:
return 255
# Convert Abode brightness (0-99) to HASS brightness (0-255)
return ceil(brightness * 255 / 99.0)

@property
def hs_color(self):
Expand Down