Skip to content

Remove vendor lookup for mac addresses#13788

Merged
balloob merged 2 commits intodevfrom
remove-mac-lookup
Apr 10, 2018
Merged

Remove vendor lookup for mac addresses#13788
balloob merged 2 commits intodevfrom
remove-mac-lookup

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 9, 2018

Description:

This removes the vendor lookup of mac addresses for newly discovered devices.

It broke when Bluetooth device trackers started to pass mac addresses that were invalid network mac addresses.

Made me realize that we should not use web services for this as it means that we're leaking what vendors we have in our house.

Related issue (if applicable): fixes #13772

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.67 milestone Apr 9, 2018
Copy link
Copy Markdown
Member

@kellerza kellerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially keep this functionality by using a downloaded copy of http://standards-oui.ieee.org/oui.txt (quite large) or https://linuxnet.ca/ieee/oui/ (nmap-mac-prefixes)

But this is a feature request...

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Apr 10, 2018

That file is too big to include for such a minor feature.

@balloob balloob merged commit 5ac52b7 into dev Apr 10, 2018
@balloob balloob deleted the remove-mac-lookup branch April 10, 2018 01:21
@disrupted
Copy link
Copy Markdown

oh but how is the average usr gonna look up the vendors now when a new device is detected? I’d say using a web service as well, it just requires an additional manual step now.

@fanaticDavid
Copy link
Copy Markdown
Contributor

I believe the web service being used was https://macvendors.com/

balloob added a commit that referenced this pull request Apr 12, 2018
* Remove vendor lookup for mac addresses

* Fix tests
@jimbob1001
Copy link
Copy Markdown

jimbob1001 commented Apr 12, 2018

Possibly unrelated but since updating to 0.67.0b1 bluetooth device mac addresses in known_devices.yaml are being prefixed with a double underscore, which then throws an error as it thinks the second underscore is part of the mac address...

mac: BT__00:11:22:33:AA:BB

@balloob balloob mentioned this pull request Apr 13, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device tracker error in 0.67.0b0

7 participants