Conversation
kellerza
left a comment
There was a problem hiding this comment.
We could potentially keep this functionality by using a downloaded copy of http://standards-oui.ieee.org/oui.txt (quite large) or https://linuxnet.ca/ieee/oui/ (nmap-mac-prefixes)
But this is a feature request...
|
That file is too big to include for such a minor feature. |
|
oh but how is the average usr gonna look up the vendors now when a new device is detected? I’d say using a web service as well, it just requires an additional manual step now. |
|
I believe the web service being used was https://macvendors.com/ |
* Remove vendor lookup for mac addresses * Fix tests
|
Possibly unrelated but since updating to 0.67.0b1 bluetooth device mac addresses in known_devices.yaml are being prefixed with a double underscore, which then throws an error as it thinks the second underscore is part of the mac address... |
Description:
This removes the vendor lookup of mac addresses for newly discovered devices.
It broke when Bluetooth device trackers started to pass mac addresses that were invalid network mac addresses.
Made me realize that we should not use web services for this as it means that we're leaking what vendors we have in our house.
Related issue (if applicable): fixes #13772
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: