Removes mistaken double underscore from new Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. #13884
Merged
kellerza merged 1 commit intohome-assistant:devfrom Apr 15, 2018
aav7fl:patch-1
Merged
Removes mistaken double underscore from new Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. #13884kellerza merged 1 commit intohome-assistant:devfrom aav7fl:patch-1
known_devices.yaml. Correcting known_devices.yaml is strongly advised. #13884kellerza merged 1 commit intohome-assistant:devfrom
aav7fl:patch-1
Conversation
Contributor
Member
|
Woohoo! Looks like we need to add a 67.1 milestone to this one :) |
Contributor
Author
|
We should somehow add a note for users to remove the entries (or modify them) with double underscores |
Member
|
@aav7fl maybe we should consider updating the ticket and title to reflect that so they know that it was introduced in 67.0 and those who updated have actions to take. Then when the PR gets merged hopefully that info will be posted with release notes :) If not the release notes always link to github and users can see this thread as well. |
known_devices.yaml. Correcting known_devices.yaml is strongly advised.
known_devices.yaml. Correcting known_devices.yaml is strongly advised. known_devices.yaml. Correcting known_devices.yaml is strongly advised.
Contributor
Author
|
@dshokouhi Done. |
Member
|
Thanks @aav7fl 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue where an additional
_was being added to bluetooth addresses (during each reboot/scan) causing thebluetoothdevice_trackerto have problems.Due to a previous update, it is strongly recommended to remove Bluetooth addresses in the
known_devices.yamlfile that may contain double underscores (__) before the mac address. This step should be performed only after updating. This will remove invalid Bluetooth address issues from the log.Related issue (if applicable): fixes #13846
Checklist:
tox. Your PR cannot be merged unless tests pass