Skip to content

Removes mistaken double underscore from new Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. #13884

Merged
kellerza merged 1 commit intohome-assistant:devfrom
aav7fl:patch-1
Apr 15, 2018

Conversation

@aav7fl
Copy link
Copy Markdown
Contributor

@aav7fl aav7fl commented Apr 14, 2018

Description:

Fixes an issue where an additional _ was being added to bluetooth addresses (during each reboot/scan) causing the bluetooth device_tracker to have problems.

Due to a previous update, it is strongly recommended to remove Bluetooth addresses in the known_devices.yaml file that may contain double underscores (__) before the mac address. This step should be performed only after updating. This will remove invalid Bluetooth address issues from the log.

Related issue (if applicable): fixes #13846

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @aav7fl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@dshokouhi
Copy link
Copy Markdown
Member

Woohoo! Looks like we need to add a 67.1 milestone to this one :)

@aav7fl
Copy link
Copy Markdown
Contributor Author

aav7fl commented Apr 14, 2018

We should somehow add a note for users to remove the entries (or modify them) with double underscores __ to prevent the logs from getting jammed up from the bug after this release.

@dshokouhi
Copy link
Copy Markdown
Member

@aav7fl maybe we should consider updating the ticket and title to reflect that so they know that it was introduced in 67.0 and those who updated have actions to take. Then when the PR gets merged hopefully that info will be posted with release notes :) If not the release notes always link to github and users can see this thread as well.

@aav7fl aav7fl changed the title fixes #13846 Double underscore in bluetooth address Removes double underscore in Bluetooth address. Updating known_devices.yaml is strongly advised. Apr 14, 2018
@aav7fl aav7fl changed the title Removes double underscore in Bluetooth address. Updating known_devices.yaml is strongly advised. Removes double underscore in Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. Apr 14, 2018
@aav7fl aav7fl changed the title Removes double underscore in Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. Removes double underscore in Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. Apr 14, 2018
@aav7fl aav7fl changed the title Removes double underscore in Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. Removes mistaken double underscore from new Bluetooth addresses in known_devices.yaml. Correcting known_devices.yaml is strongly advised. Apr 14, 2018
@aav7fl
Copy link
Copy Markdown
Contributor Author

aav7fl commented Apr 14, 2018

@dshokouhi Done.

@kellerza kellerza merged commit 2bff038 into home-assistant:dev Apr 15, 2018
@kellerza kellerza added this to the 0.67.1 milestone Apr 15, 2018
@kellerza
Copy link
Copy Markdown
Member

Thanks @aav7fl 🎉

@aav7fl aav7fl deleted the patch-1 branch April 15, 2018 13:21
@balloob balloob mentioned this pull request Apr 18, 2018
@balloob balloob removed this from the 0.67.1 milestone Apr 18, 2018
@balloob balloob mentioned this pull request Apr 27, 2018
@balloob balloob added this to the 0.67.1 milestone Apr 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.67.0b1 - BT mac addresses get prefixed with double underscore in known_devices.yaml

6 participants