Skip to content

Use pihole module to get data#14809

Merged
MartinHjelmare merged 1 commit intodevfrom
pi-hole
Jun 4, 2018
Merged

Use pihole module to get data#14809
MartinHjelmare merged 1 commit intodevfrom
pi-hole

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Jun 4, 2018

Description:

  • Use third-party module to get the data
  • Add new condition

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5492

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: pi_hole
    host: 192.168.0.215

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@MartinHjelmare MartinHjelmare changed the title Use module to get data Use pihole module to get data Jun 4, 2018
@MartinHjelmare MartinHjelmare merged commit 816efa0 into dev Jun 4, 2018
@fabaff fabaff deleted the pi-hole branch June 10, 2018 08:30
@balloob balloob mentioned this pull request Jun 22, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants