Merged
Conversation
balloob
requested review from
a team,
Danielhiversen,
emlove and
syssi
as code owners
balloob
force-pushed
the
frontend-websocket
branch
from
c519a98 to
3411524
Compare
pvizeli
approved these changes
Jun 6, 2018
| 'Received invalid command: {}'.format(msg['type'])) | ||
| self.to_write.put_nowait(error_message( | ||
| cur_id, ERR_UNKNOWN_COMMAND, | ||
| 'Unknown command.')) |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Move themes and translations frontend APIs from being over HTTP to be over the websocket connection.
Frontend PR: home-assistant/frontend#1260
Example entry for
configuration.yaml(if applicable):frontend:Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: