Skip to content

Fix non awaited test#14854

Merged
fabaff merged 1 commit intodevfrom
fix-non-awaited-test
Jun 7, 2018
Merged

Fix non awaited test#14854
fabaff merged 1 commit intodevfrom
fix-non-awaited-test

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jun 7, 2018

Description:

Whenever we would run the tests, we had a warning that one test method was never awaited.

This PR fixes that.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Jun 7, 2018
@ghost ghost assigned balloob Jun 7, 2018
@ghost ghost added the in progress label Jun 7, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit bf74cab into dev Jun 7, 2018
@ghost ghost removed the in progress label Jun 7, 2018
@fabaff fabaff deleted the fix-non-awaited-test branch June 7, 2018 13:58
@balloob balloob mentioned this pull request Jun 22, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants