Move core service from core to components

[pvizeli]

Description:

That split core Service to components like discus on #5609. I think that is the core clean variant.
I copy the good work from @andrey-git and change the handling of that PR.

I add also a new Service check_config to run config Validation.

CC @balloob

• move unittests

[mention-bot]

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @fabianhjr to be potential reviewers.

[andrey-git]

The "not restarting" part might no longer be relevant as there is a separate service to just check the config.

[pvizeli]

👍

[andrey-git]

There are more users of those handlers: Sigterm, KeyboardInterrupt

[pvizeli]

👍

[pvizeli]

Done. I call now the service.

[andrey-git]

Also _async_restart_handler for sighup :)

[pvizeli]

I change the handling of that see on comment.

[andrey-git]

I think such a dependency is a hack.
homeassistant.config shouldn't depend on homeassistant.components.*

[pvizeli]

This depense will exists without I Import this or not... Bootstrap work in same way.

[andrey-git]

We could call persistence notification service then there will be no dependency - i.e. hass would still come up if homeassistant.components.persistent_notification was removed.

[andrey-git]

LIke in homeassistant.core you call a service and not call homeassistant.components.stop()

[pvizeli]

I think it will become the same if I import this or I need to do: from ...persistent_notification Import DOMAIN, SERVICE_XY for calling the service later.

[andrey-git]

Yes, so I propose not to import anything and just use strings to call the service.

[balloob]

It's a hack but one that we use in other places in this file too, see line 31. However, line 31 does execute it a bit more classy, as it allows for people to overwrite that component.

I prefer to use the function over spelling out the service, because that's the suggested way for Python code.

[andrey-git]

This means there can be 2 notifications Icheck, restart) meaning the same thing.
I think we should use the same ID.

[pvizeli]

I merge only the Service for start/restart into components. The function is used also by signal handler and other deep core stuff. It make no sense to move this core stuff also into component.

[andrey-git]

I think SIGHUP we should also check that config is valid - otherwise the service will just go down.

[pvizeli]

On most posix system with systemd will kill the hole hass if SIGHUP do nothing. I think a Administrator on console have a reason do to some things and he have the possibility to check self.

[balloob]

Can we rename these to async_stop() and take 0 arguments.

Will need to update the signal handlers to properly wrap the call.

[balloob]

Oh, async_stop already exists. Well, in that case can we move assigning exit_code into that method and remove async_stop_handler completely?

[balloob]

Same

[balloob]

We should rename this to async_restart:

def async_restart(self):
    self.exit_code = RESTART_EXIT_CODE
    return self.async_stop()

And if we default exit_code to 0, async_stop doesn't have to assign anything.

[balloob]

I think that we should also extract the signal handling of the core.

[pvizeli]

Yeah, make a new PR for that

[balloob]

Nice 🐬