Closed
Conversation
emlove
force-pushed
the
xy-color-support
branch
from
fb7e5de to
8f472af
Compare
emlove
force-pushed
the
xy-color-support
branch
from
8f472af to
af483eb
Compare
balloob
reviewed
Dec 24, 2017
| @@ -284,7 +284,8 @@ | |||
| fireColorSelected(hsv) { | |||
| this.hsvColor = hsv; | |||
| this.rgbColor = this.HSVtoRGB(this.hsvColor); | |||
Member
There was a problem hiding this comment.
Since we don't use this anymore it can be removed?
Contributor
Author
|
Closing this, since we're moving towards using hue/sat for color. I'll create a new PR once home-assistant/core#11288 is merged to make use of the hue/sat API and get rid of the extra conversion here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently if an entity only supports XY color, it won't get a color picker on the frontend. This PR shows the color picker, and makes XY color the preferred format to send colors to the backend. Because XY doesn't combine brightness with the color, using XY helps prevent unintended brightness changes when making selections on the color picker.