Skip to content
This repository was archived by the owner on Oct 30, 2019. It is now read-only.

Added install script for Homebridge.#79

Merged
Landrash merged 7 commits into
home-assistant:devfrom
ludeeus:patch-5
Jan 28, 2018
Merged

Added install script for Homebridge.#79
Landrash merged 7 commits into
home-assistant:devfrom
ludeeus:patch-5

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Jan 6, 2018

As stated in the title and README this will install and configure Homebridge with Home Assistant addon.

@ludeeus ludeeus mentioned this pull request Jan 8, 2018
19 tasks
- I samba is installed, users get option to expose `/home/homebridge/.homebridge` as `homebridge` user
- Corrected some language formatting
- Corrected discord channel in failed state
@ludeeus ludeeus changed the title Added install script for Homebridge Added install script for Homebridge. Jan 12, 2018
@Landrash Landrash added this to the v0.7 milestone Jan 27, 2018
Copy link
Copy Markdown
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The creation of a folder should be handled by the correct flag with useradd instead of added manually. This to make sure that the proper permissions are applied to the home directory.


echo "Adding homebridge user, and creating config file..."
sudo useradd -M --system homebridge
sudo mkdir /home/homebridge
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be able to be replaced by creating the home directory with useradd?

Copy link
Copy Markdown
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🍰

@Landrash Landrash merged commit f450028 into home-assistant:dev Jan 28, 2018
@ludeeus ludeeus deleted the patch-5 branch January 28, 2018 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants