fix: re-read request body from incoming.rawBody if available#223
Merged
yusukebe merged 1 commit intohonojs:mainfrom Jan 30, 2025
Merged
fix: re-read request body from incoming.rawBody if available#223yusukebe merged 1 commit intohonojs:mainfrom
incoming.rawBody if available#223yusukebe merged 1 commit intohonojs:mainfrom
Conversation
In some environments (e.g. firebase functions), the body is already consumed, but we can re-read the request body from `incoming.rawBody` in that case.
Member
Author
|
@yusukebe |
|
Would this mean, with this fix, we can just reuse the |
Member
|
Hi @usualoma This fix is interesting. And the honojs/hono#1695 is completely fixed by this! I'll merge it now. Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments (e.g. firebase functions), the body is already consumed, but we can re-read the request body from
incoming.rawBodyin that case.fix honojs/hono#1695