perf: improve body read performance#311
Conversation
6459306 to
d05b374
Compare
d05b374 to
950d462
Compare
|
Hi @yusukebe It's worth noting that a considerable amount of code is required, but I don't believe the complexity is so overwhelming that it becomes unmanageable if issues arise. Considering the significant speed improvement, accepting this level of complexity as a trade-off seems reasonable. (Plus, we can leverage AI for maintenance.) What do you think? If it's acceptable, please merge this. With this PR, I assume my additions to pref/request-v2 (oops, I mistyped the branch name) are complete. |
|
Hi @usualoma, I'll review this soon. On my machine (MacBook Pro / M4 Pro) the benchmark result is below. Though, it is wonderful:
|
|
Hey @usualoma Looks great to me! I'll merge this into the |
|
Hey @usualoma ! I created the This is because a CI did not run on this PR's branch, so you missed the error. Can you take a look at it and fix the code so it passes CI? Thanks. |
|
Oh, sorry, I forgot to test it after making some last-minute adjustments. |
|
@usualoma No problem! |

This PR applies fixes to maintain compatibility with web standards for the request body optimization merged in #301.
It seems we can implement this without significantly reducing the performance gains, but it will likely require a considerable amount of code. Maintenance costs also look substantial.