Skip to content

feat: cu profiling section update#63

Open
C0mberry wants to merge 15 commits intodevelopment-cu-profiling-instruction-namefrom
feat-cu-profiling-instruction-name
Open

feat: cu profiling section update#63
C0mberry wants to merge 15 commits intodevelopment-cu-profiling-instruction-namefrom
feat-cu-profiling-instruction-name

Conversation

@C0mberry
Copy link
Copy Markdown

@C0mberry C0mberry commented Dec 16, 2025

Description

  • adding instruction and program name to cu profiling tooltip
  • adding total/requested cu units to heading

Type of change

  • Bug fix
  • New feature
  • Protocol integration
  • Documentation update
  • Other (please describe):

Screenshots

Screenshot 2025-12-16 at 13 15 59

Testing

http://localhost:3000/tx/3RXTbQBXfHjNvSuBPbJx3BK3CUZrxzQXoiRiDojLwhHV72y1Xg885K2rt6cgKrECMZkNzT42SqH1fmHLUXWAp6FX?cluster=devnet

Checklist

  • My code follows the project's style guidelines
  • I have added tests that prove my fix/feature works
  • All tests pass locally and in CI
  • I have updated documentation as needed
  • CI/CD checks pass
  • I have included screenshots for protocol screens (if applicable)
  • For security-related features, I have included links to related information

@C0mberry C0mberry self-assigned this Dec 16, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
explorer Ready Ready Preview, Comment Jan 14, 2026 2:48pm

@C0mberry C0mberry marked this pull request as ready for review December 16, 2025 11:03
@C0mberry C0mberry requested a review from rogaldh December 16, 2025 11:03
@rogaldh
Copy link
Copy Markdown

rogaldh commented Dec 16, 2025

Please don't forget to paste a link to the sample instruction

@rogaldh
Copy link
Copy Markdown

rogaldh commented Dec 16, 2025

Could you, please, check that Compute Budget Program's tooltip contains instruction name as well?
http://localhost:3000/tx/26kPcgGdACHqW5E9fBbKv3P2pzCHyFd1amtioAvkdRZkHauRC8DBvncSCwjxkwrsgZrMWXf4SQ2tPmUBgYwee52n
image

@rogaldh
Copy link
Copy Markdown

rogaldh commented Dec 18, 2025

Please check this link http://localhost:3000/tx/u3swuUP5Za9Hqf2i4HK9M7CcQw98YqtjrMjub2zjvh9u7cN65PoPKcAvPfdyZnY8PDof4sZvBfK34qVBrtSDjGq/inspect
Looks like we need to check that bars are visible

@rogaldh
Copy link
Copy Markdown

rogaldh commented Dec 18, 2025

image

http://localhost:3000/tx/4Vyh3doiNqM41VxBpvzhzD6Aq9hELt6xq6xwK13snBScPtHeqMTi2WvPDvV2yesWyt2DaMtbG2b1udhh35NMxbrq/inspect

Could you, please, check this transaction. It contains instructions for ComputeBudget and ATA programs. Let's do this:

  • add instruction names for these programs
  • build the code in a way to add names for instructions for other programs in future
    • We should definitely have a small comment in the code with explanations to support other program instructions.

I've discovered there are names for instructions on the transaction page, but not on the transaction inspector page. Instruction name resolving should work for both

@rogaldh
Copy link
Copy Markdown

rogaldh commented Dec 23, 2025

Last nits:

I have hypothesis that this is because of simulation errors on the inspector page. But if this is true, why does we have names partially as on the screen, link:

image

@rogaldh
Copy link
Copy Markdown

rogaldh commented Dec 23, 2025

Overall structure looks good. It will help us in the future to parse the names for other programs. Maybe we can make an attempt to parse instructions for inspector the same way we do for cards. But that will be critical change imo.
Thanks.

@C0mberry
Copy link
Copy Markdown
Author

@rogaldh
Copy link
Copy Markdown

rogaldh commented Mar 18, 2026

Overall structure looks good. It will help us in the future to parse the names for other programs. Maybe we can make an attempt to parse instructions for inspector the same way we do for cards. But that will be critical change imo. Thanks.

I think let's cover parsing later. Could you please make a quick check that all works, and let's create a PR to the upstream

Copy link
Copy Markdown

@rogaldh rogaldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants