Skip to content

feat: make service log level configurable#151

Closed
dvag-gloeckner-daniel wants to merge 1 commit intohoverkraft-tech:mainfrom
dvag-gloeckner-daniel:feat/compose-logs
Closed

feat: make service log level configurable#151
dvag-gloeckner-daniel wants to merge 1 commit intohoverkraft-tech:mainfrom
dvag-gloeckner-daniel:feat/compose-logs

Conversation

@dvag-gloeckner-daniel
Copy link
Contributor

@dvag-gloeckner-daniel dvag-gloeckner-daniel commented May 21, 2025

This change introduces the feature discussed in
#150.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for creating your PR, we will check it out very soon

@dvag-gloeckner-daniel
Copy link
Contributor Author

@neilime there seem to be some environmental issues regarding CI tests
https://github.com/hoverkraft-tech/compose-action/actions/runs/15158124313/job/42617806352

@dvag-gloeckner-daniel dvag-gloeckner-daniel force-pushed the feat/compose-logs branch 5 times, most recently from edc14f7 to bcf056d Compare May 21, 2025 09:42
@dvag-gloeckner-daniel
Copy link
Contributor Author

@neilime I think the CI pipeline does not work for PRs from forks. What's the way forward? :)

Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename service-log-level to services-log-level

Thanks

@dvag-gloeckner-daniel
Copy link
Contributor Author

@neilime services-log-level it is :)

@neilime
Copy link
Member

neilime commented May 26, 2025

@neilime services-log-level it is :)

Thanks, can you run npm run all to be sure all is OK?

@neilime neilime linked an issue May 26, 2025 that may be closed by this pull request
@dvag-gloeckner-daniel
Copy link
Contributor Author

I ran npm run all. Tests are green, linter is happy, code is properly formatted.

But I forgot to update the compiled js under dist. Pushed that right now.

@dvag-gloeckner-daniel
Copy link
Contributor Author

@neilime now we're back to the failing CI due to "Error: Failed to get odic token, did you forget the permissions: { id-token: write } permission in your caller workflow, alternatively permissions: write-all works too: Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable"

@dvag-gloeckner-daniel
Copy link
Contributor Author

@neilime anything I could help with to fix the CI build? Maybe PRs from forks are not working in the current setup?

@dvag-gloeckner-daniel
Copy link
Contributor Author

@neilime please have a look again :)

@neilime
Copy link
Member

neilime commented Jun 19, 2025

@dvag-gloeckner-daniel there is a new security blocking point with GitHub Actions:

OIDC is not available to workflows triggered by pull_request from forks for security reasons.

I've "cloned" the PR to validate it properly: #159

@neilime neilime closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log Level for Docker Compose should be configurable

2 participants