added code docu #37
Merged
added code docu #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
msoechting
requested changes
Jan 24, 2018
| * | ||
| * Adds a given NPM module to the JavaScript context. | ||
| * This is achieved by calling `require('module_name')`. | ||
| * *Important* Make sure the NPM module is installed before using this method. |
Collaborator
There was a problem hiding this comment.
Where does this module need to be installed? Globally? Or locally (which folder though?)?
Collaborator
There was a problem hiding this comment.
Here's how node finds its modules: https://nodejs.org/api/modules.html#modules_all_together
Note: We haven't properly solved this with our qt app (yet).
src/node_lib.h
Outdated
| * | ||
| * Loads and executes the content of the given file. | ||
| * This method returns after the script was evaluated once. | ||
| * This means, that any pending events will not be processes as long as |
src/node_lib.h
Outdated
| * | ||
| * Issues the Node.js event loop to stop. | ||
| * The event loop will finish its current execution. | ||
| * This means, that the loop is not stopped when this method returns. |
Collaborator
There was a problem hiding this comment.
Suggestion for more clarity: "...that the loop is not guaranteed to have stopped when this method returns."
* added error handling via MaybeLocal * implemented missing method * re-enabled scope.Escape in order to save the script return value
* Add support for cmd args * Move setCmdArgs code to ctor * Fix cmd options * Fix visibility and comments in CmdArgs * Improve documentation
Expose Internals
msoechting
approved these changes
Jan 30, 2018
Improve TickEventLoop()
changed the way internals are exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote doxygen docu for our interface.
closes #30