Skip to content

[Snyk] Fix for 1 vulnerabilities#452

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-027fc0419977dfb74c9b428a5981a3bb
Open

[Snyk] Fix for 1 vulnerabilities#452
q1blue wants to merge 2 commits intonextfrom
snyk-fix-027fc0419977dfb74c9b428a5981a3bb

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 16, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/presets/vue3-webpack/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the project's security posture by resolving a critical vulnerability. It involves updating specific package dependencies to patched versions, thereby mitigating the risk of a Regular Expression Denial of Service attack.

Highlights

  • Security Vulnerability Fix: This pull request, automatically generated by Snyk, addresses a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295) found in the project's yarn dependencies.
Changelog
  • code/presets/vue3-webpack/package.json
    • Updated @storybook/core-webpack from workspace:* to 7.0.0.
    • Updated webpack from 5 to 5.98.0.
Activity
  • This pull request was automatically created by Snyk to fix identified vulnerabilities.
  • A warning is present indicating that the yarn.lock file failed to update and requires manual intervention.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix a ReDoS vulnerability by updating dependencies. While the update to the webpack package to version 5.98.0 is correct and likely addresses the vulnerability, the change to @storybook/core-webpack is problematic. It replaces the workspace:* reference with a hardcoded version 7.0.0, which is a major version downgrade and breaks the monorepo's yarn workspace setup. This change should be reverted. Additionally, as noted in the PR description, the yarn.lock file has not been updated. It is critical to run yarn install and commit the updated yarn.lock file to ensure dependency resolution is consistent and the fix is correctly applied across the project.

},
"dependencies": {
"@storybook/core-webpack": "workspace:*",
"@storybook/core-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:* to a fixed version 7.0.0 for @storybook/core-webpack is incorrect. It breaks the yarn workspace linkage for a package within this monorepo. The current version of @storybook/core-webpack in the workspace is 8.3.0-beta.3, so this change is also a major version downgrade which will likely cause build failures. This should be reverted back to "workspace:*" to maintain the monorepo's integrity. The vulnerability fix is likely from the webpack dependency update in this same file.

Suggested change
"@storybook/core-webpack": "7.0.0",
"@storybook/core-webpack": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants