LoftQ: edit README.md and example files#1276
Merged
Merged
Conversation
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thank you! Left a single comment
| return base_model_dir, lora_model_dir | ||
|
|
||
|
|
||
| def load_loftq(base_model_path, lora_adapter_path): |
Contributor
There was a problem hiding this comment.
Why this has been removed?
Contributor
There was a problem hiding this comment.
I think this function was supposed to confirm that everything works fine after the loftq weight initialization step. Hence, not a required step.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Dec 18, 2023
Due to PR huggingface#1276, the bug that prevented use of LoftQ with 8bit quantization has now been fixed. Therefore, the tests no longer need to be skipped. Note I tested locally with GPU and the tests passed.
This was referenced Dec 18, 2023
BenjaminBossan
added a commit
that referenced
this pull request
Dec 18, 2023
Due to PR #1276, the bug that prevented use of LoftQ with 8bit quantization has now been fixed. Therefore, the tests no longer need to be skipped.
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
* fix when num_bits == 2 or 8 * try 13b
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
Due to PR huggingface#1276, the bug that prevented use of LoftQ with 8bit quantization has now been fixed. Therefore, the tests no longer need to be skipped.
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
* Update sft_trainer.py * Update trl/trainer/sft_trainer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to update the README.md file and example scripts for LoftQ