Implement import allowlist in AutoPeftModel, limit access in megatron#3090
Open
githubnemo wants to merge 3 commits intohuggingface:mainfrom
Open
Implement import allowlist in AutoPeftModel, limit access in megatron#3090githubnemo wants to merge 3 commits intohuggingface:mainfrom
githubnemo wants to merge 3 commits intohuggingface:mainfrom
Conversation
added 3 commits
March 11, 2026 12:30
Partially resolves huggingface#3085. AutoPeftModel resolves the base model's class by importing the parent library mentioned in the adapter config which makes way for potentially executing malicious code on the adapter creator's behalf. While this is not a remote code execution vulnerability by itself (since the attacker still needs to install a malicious package on the system) it can be used for code execution in case the attacker has file system access, for example.
I haven't found any evidence that one wants to load other modules than `megatron.*`, so we limit it to that.
Collaborator
Author
|
cc @spartan8806 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for the quick turnaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3085.
AutoPeftModelresolves the base model's class by importing the parent library mentioned in the adapter config which makes way for potentially executing malicious code on the adapter creator's behalf. While this is not a remote code execution vulnerability by itself (since the attacker still needs to install a malicious package on the system) it can be used for code execution in case the attacker has file system access, for example.The same is happening for the
megatron.coreconfig key. I haven't found any evidence thatmegatronwants to load other modules thanmegatron.*, so we limit it to that.There was a bit of missing documentation, typo, missing
hub_online_once, so I took the opportunity to fix that along the way.