Exclude compatibility versions from .[dev] install

[tomaarsen]

Hello!

Pull Request overview

• Fix bug for dev install that causes older versions of datasets, sentence-transformers and evaluate to be installed.

Bug details

In the setup.py, the following line creates a list of requirements for the compatibility CI tester, i.e. a tester that runs on the lowest working versions of datasets, sentence-transformers and evaluate.

setfit/setup.py

Line 24 in 0cb8ffd

COMPAT_TESTS_REQUIRE = [requirement.replace(">=", "==") for requirement in REQUIRED_PKGS] + TESTS_REQUIRE

It is not meant to be used by anyone in practice. It is added to this dictionary for easier installing on the CI runner's side:

setfit/setup.py

Lines 26 to 33 in 0cb8ffd

	EXTRAS_REQUIRE = {
	"optuna": INTEGRATIONS_REQUIRE,
	"quality": QUALITY_REQUIRE,
	"tests": TESTS_REQUIRE,
	"onnx": ONNX_REQUIRE,
	"openvino": ONNX_REQUIRE + OPENVINO_REQUIRE,
	"compat_tests": COMPAT_TESTS_REQUIRE,
	}

But, afterwards, the dev install is set, which includes all requirements from EXTRAS_REQUIRE, including the compatibility requirements:

setfit/setup.py

Line 40 in 0cb8ffd

EXTRAS_REQUIRE["dev"] = combine_requirements([k for k in EXTRAS_REQUIRE])

Before this PR

This bug causes the following dev requirements:

>>> EXTRAS_REQUIRE["dev"]
['evaluate==0.3.0', 'flake8', 'black', 'hummingbird-ml', 'pytest-cov', 'pytest', 'openvino>=2022.3', 'optuna', 'onnxruntime', 'skl2onnx', 'sentence-transformers==2.2.1', 'datasets==2.3.0', 'isort', 'onnx', 'tabulate']

As you'll note, this includes 'evaluate==0.3.0', 'sentence-transformers==2.2.1' and 'datasets==2.3.0'.

The fix

I've simply moved the compatibility test requirements down to below where the dev requirements are specified. I also reformatted the file slightly.

After this PR

>>> EXTRAS_REQUIRE["dev"]
['onnx', 'flake8', 'pytest', 'hummingbird-ml', 'onnxruntime', 'skl2onnx', 'black', 'tabulate', 'isort', 'pytest-cov', 'openvino>=2022.3', 'optuna']

As you can see, the compatibility test versions have been removed.

• Tom Aarsen

[lewtun]

Thanks for the fix! LGTM :)