Refactor training logs & warmup_proportion #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #473
Hello!
Pull Request overview
args.max_stepsDetails
Training logs
Now we display the number of unique pairs (instead of number of examples, which was broken). The rest is only updated slightly.
Update how warmup_steps are defined
It now uses number of training samples if training samples >
args.max_stepsalongside thewarmup_proportion. This should make thewarmup_proportionmatch reality.Thanks @michael-brunzel for raising this!