Skip to content

Conversation

@tomaarsen
Copy link
Member

Resolves #473

Hello!

Pull Request overview

  • Refactor training logs.
  • Update how warmup_steps are defined, now uses number of training samples if training samples > args.max_steps

Details

Training logs

Now we display the number of unique pairs (instead of number of examples, which was broken). The rest is only updated slightly.

Update how warmup_steps are defined

It now uses number of training samples if training samples > args.max_steps alongside the warmup_proportion. This should make the warmup_proportion match reality.

Thanks @michael-brunzel for raising this!

  • Tom Aarsen

Now we display the number of unique pairs (instead of number of examples, which was broken).
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tomaarsen tomaarsen merged commit 6024ed4 into huggingface:main Jan 16, 2024
@tomaarsen tomaarsen deleted the fix/update_train_logs branch January 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Displayed "Num examples" after the training start seems wrong

2 participants