Skip to content

[Trainer] Fix default data collator#30142

Merged
NielsRogge merged 2 commits intohuggingface:mainfrom
NielsRogge:fix_data_collator_trainer
Apr 9, 2024
Merged

[Trainer] Fix default data collator#30142
NielsRogge merged 2 commits intohuggingface:mainfrom
NielsRogge:fix_data_collator_trainer

Conversation

@NielsRogge
Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR isolates a fix proposed in #30129, namely the DataCollatorWithPadding only needs to be used in case a tokenizer is being passed and is effectively a tokenizer or feature extractor, not another object like an image processor.

@NielsRogge NielsRogge requested a review from amyeroberts April 9, 2024 10:00
Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@NielsRogge NielsRogge merged commit ba1b24e into huggingface:main Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants