Explicitly setting encoding in tokenization_utils_base.py#38553
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Jun 3, 2025
Merged
Explicitly setting encoding in tokenization_utils_base.py#38553Rocketknight1 merged 1 commit intohuggingface:mainfrom
Rocketknight1 merged 1 commit intohuggingface:mainfrom
Conversation
6 tasks
Rocketknight1
approved these changes
Jun 3, 2025
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, thank you for catching this!
Add encoding explicitly
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bvantuan
pushed a commit
to bvantuan/transformers
that referenced
this pull request
Jun 12, 2025
…e#38553) Update tokenization_utils_base.py Add encoding explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add encoding explicitly
What does this PR do?
Problem:
When loading tokenizers, specifically those that utilize a chat_template.jinja file (e.g., THUDM/GLM-4-9B-0414), a UnicodeDecodeError can occur in certain environments. This happens because the open() call defaults to the system's preferred encoding, which can unexpectedly revert to ASCII (ANSI_X3.4-1968) within subprocesses, particularly in torch.distributed settings or isolated container environments.
The root cause is that these subprocesses may not correctly inherit LANG, LC_ALL, or LC_CTYPE environment variables from the parent shell, leading locale.getpreferredencoding() to return ASCII instead of UTF-8. This results in the following traceback when encountering non-ASCII bytes (e.g., 0xe5) in the chat_template.jinja file:
Solution:
This PR explicitly sets the encoding="utf-8" parameter when opening the file. It then works as expected.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.