Skip to content

[Trainer] Move NEFTune impl to standalone functions#43714

Merged
SunMarc merged 6 commits intomainfrom
move-neftune
Feb 5, 2026
Merged

[Trainer] Move NEFTune impl to standalone functions#43714
SunMarc merged 6 commits intomainfrom
move-neftune

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Feb 3, 2026

What does this PR do ?

This PR refactor NEFTune implementation from Trainer methods to standalone functions. Part of PRs to unbloat Trainer.

@SunMarc SunMarc changed the title [Trainer] Move NEFTune impl to standalone functions. [Trainer] Move NEFTune impl to standalone functions Feb 3, 2026
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc SunMarc requested a review from kashif February 5, 2026 14:37
@SunMarc
Copy link
Member Author

SunMarc commented Feb 5, 2026

cc @winglian

@SunMarc SunMarc requested review from winglian February 5, 2026 15:25
SunMarc and others added 2 commits February 5, 2026 17:35
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
@SunMarc
Copy link
Member Author

SunMarc commented Feb 5, 2026

@bot /style

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Style fix bot fixed some files and pushed the changes.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, better this way!

@SunMarc SunMarc merged commit 393b4b3 into main Feb 5, 2026
26 checks passed
@SunMarc SunMarc deleted the move-neftune branch February 5, 2026 18:58
jiosephlee pushed a commit to jiosephlee/transformers_latest that referenced this pull request Feb 11, 2026
* style

* update

* Apply suggestion from @kashif

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>

* Apply suggestion from @kashif

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>

* Apply repo consistency fixes

---------

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants