Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
/trl-ci |
Member
|
if it's just a reordering, why |
Member
Author
|
I've updated the docstring + typing also ! Also with the creation of sections, there are some comments that were added. |
qgallouedec
approved these changes
Feb 11, 2026
Member
qgallouedec
left a comment
There was a problem hiding this comment.
lgtm! I didn't check that the re-ordering is correct, but the new order from the PR description looks good! https://github.com/huggingface/trl/actions/runs/21912922535 is red but it's not related to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reorder all methods from Trainer. No modifications was done to the methods itself. With this final PR, all the major changes should be done and we can focus on simplifying the core logic + testing.
Reordering makes it hard to go back to previous PRs with git blame so a follow-up would be to create a
.git-blame-ignore-revsfile as this enables github to automatically skip those commits when using blame.Here's the structure for now: