Skip to content

Bump torchao >=0.15 and fix quantization CI#44604

Merged
SunMarc merged 23 commits intomainfrom
fix-quants-tests
Mar 16, 2026
Merged

Bump torchao >=0.15 and fix quantization CI#44604
SunMarc merged 23 commits intomainfrom
fix-quants-tests

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Mar 11, 2026

What does this PR do?

This PR fix the quantization CI :

  • autoround
  • bnb
  • fp_quant_integration
  • metal
  • mxfp4
  • quark_integration
  • torchao_integration

One major point in this PR is that I bump the min version of torchao to 0.15.0, thus we can clean a bunch of things.

@SunMarc
Copy link
Member Author

SunMarc commented Mar 11, 2026

run-slow: metal, mxfp4, fp_quant_integration, autoround

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/autoround", "quantization/fp_quant_integration", "quantization/metal", "quantization/mxfp4"]

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 53bfea2b workflow commit (merge commit)
PR 5c21405c branch commit (from PR)
main e45078f2 base commit (on main)

Quantization CI Report

3 new failed tests from this PR 😭

  • metal:
    tests/quantization/metal/test_metal.py::MetalSlowIntegrationTest::test_quantized_model (❌ ⟹ ❌)

  • mxfp4:
    tests/quantization/mxfp4/test_mxfp4.py::Mxfp4QuantizerTest::test_quantizer_validation_no_accelerator (❌ ⟹ ❌)
    tests/quantization/mxfp4/test_mxfp4.py::Mxfp4QuantizerTest::test_quantizer_validation_order_dequantize_before_accelerator_check (❌ ⟹ ❌)

@SunMarc
Copy link
Member Author

SunMarc commented Mar 11, 2026

run-slow: bnb, fp_quant_integration, metal, mxfp4

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/bnb", "quantization/fp_quant_integration", "quantization/metal", "quantization/mxfp4"]

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 3767b4e5 workflow commit (merge commit)
PR e99da79a branch commit (from PR)
main 0a9fdeaa base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@SunMarc
Copy link
Member Author

SunMarc commented Mar 12, 2026

run-slow: bnb, fp_quant_integration, quark_integration

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/bnb", "quantization/fp_quant_integration", "quantization/quark_integration"]

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 7fb024b1 workflow commit (merge commit)
PR 6c9c89d9 branch commit (from PR)
main e5a861d3 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@SunMarc
Copy link
Member Author

SunMarc commented Mar 12, 2026

run-slow: bnb

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/bnb"]

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 7fb024b1 workflow commit (merge commit)
PR 6c9c89d9 branch commit (from PR)
main e5a861d3 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@SunMarc
Copy link
Member Author

SunMarc commented Mar 13, 2026

run-slow: torchao

@SunMarc
Copy link
Member Author

SunMarc commented Mar 13, 2026

run-slow: torchao_integration

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/torchao_integration"]

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 464c2078 workflow commit (merge commit)
PR 234cbb11 branch commit (from PR)
main f2f7c894 base commit (on main)

Quantization CI Report

1 new failed tests from this PR 😭

  • torchao_integration:
    tests/quantization/torchao_integration/test_torchao.py::TorchAoSerializationTest::test_serialization_accelerator_5 (✅ ⟹ ❌)

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 82d7a58c workflow commit (merge commit)
PR 4031b7ae branch commit (from PR)
main 064f0e97 base commit (on main)

Quantization CI Report

1 new failed tests from this PR 😭

  • torchao_integration:
    tests/quantization/torchao_integration/test_torchao.py::TorchAoAcceleratorTest::test_int4wo_offload (❌ ⟹ ❌)

@SunMarc SunMarc changed the title Fix quantization CI Bump torchao >=0.15 and fix quantization CI Mar 16, 2026
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SunMarc
Copy link
Member Author

SunMarc commented Mar 16, 2026

run-slow: bnb, fp_quant_integration, metal, mxfp4, quark_integration, torchao_integration

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/bnb", "quantization/fp_quant_integration", "quantization/metal", "quantization/mxfp4", "quantization/quark_integration", "quantization/torchao_integration"]

BenjaminBossan added a commit to BenjaminBossan/peft that referenced this pull request Mar 16, 2026
Torchao made some API changes, which have to be reflected in the tests.
Moreover, for this to pass, we also need transformers to make the
corresponding adjustments:

huggingface/transformers#44604

While working on this, I migrated the tests from unittest to pytest
style.
@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 81e5d278 workflow commit (merge commit)
PR f2753d47 branch commit (from PR)
main d64a6d67 base commit (on main)

Quantization CI Report

1 new failed tests from this PR 😭

  • torchao_integration:
    tests/quantization/torchao_integration/test_torchao.py::TorchAoAcceleratorTest::test_int4wo_offload (❌ ⟹ ❌)

@github-actions
Copy link
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44604&sha=d63de4

@SunMarc
Copy link
Member Author

SunMarc commented Mar 16, 2026

run-slow: bnb, fp_quant_integration, metal, mxfp4, quark_integration, torchao_integration, fouroversix

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/bnb", "quantization/fp_quant_integration", "quantization/metal", "quantization/mxfp4", "quantization/quark_integration", "quantization/torchao_integration"]

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 9b030796 workflow commit (merge commit)
PR d63de446 branch commit (from PR)
main 30adbf3f base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@SunMarc
Copy link
Member Author

SunMarc commented Mar 16, 2026

Omg everything is green

@SunMarc SunMarc enabled auto-merge March 16, 2026 15:32
@SunMarc SunMarc disabled auto-merge March 16, 2026 15:32
@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: bnb, fp_quant_integration, metal, mxfp4, quark_integration, torchao_integration

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: bnb, fp_quant_integration, metal, mxfp4, quark_integration, torchao_integration

@SunMarc SunMarc enabled auto-merge March 16, 2026 15:53
@SunMarc SunMarc added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit bfe00b4 Mar 16, 2026
16 of 17 checks passed
@SunMarc SunMarc deleted the fix-quants-tests branch March 16, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants