Skip to content

Add TF variants to README#6

Merged
TobiasBabin merged 15 commits intomainfrom
add-tf-to-readme
Mar 25, 2026
Merged

Add TF variants to README#6
TobiasBabin merged 15 commits intomainfrom
add-tf-to-readme

Conversation

@TobiasBabin
Copy link
Copy Markdown
Contributor

@TobiasBabin TobiasBabin commented Feb 10, 2026

This PR adds the Terraform/OpenTofu variants to the existing CLI commands for setting up the core resource type and module in the main README.

It also fixes an error in the hctl create resource-type score-workload command where an extra "'" rendered the command not functional.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the main README to include Terraform/OpenTofu (HCL) equivalents alongside existing hctl CLI examples for creating the score-workload resource type and installing/configuring the module.

Changes:

  • Add Terraform/OpenTofu examples for creating the score-workload resource type.
  • Add Terraform/OpenTofu examples for creating the score-workload module and configuring inputs.
  • Expand the dynamic namespace section with Terraform/OpenTofu dependency + placeholder examples.
Comments suppressed due to low confidence (1)

README.md:106

  • The CLI examples are inconsistent about whether the module id/name is passed as a positional argument. Earlier you use hctl create module score-workload ..., but this later example shows hctl create module \ without specifying the module id. Make this consistent (either include the module id here too, or show the equivalent --set=id=... form if that’s the intended syntax).
hctl create module \
    ...
    --set=module_inputs='{"namespace": "my-namespace", "service_account_name": "my-sa", "wait_for_rollout": false}'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 10, 2026 12:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

README.md:106

  • The CLI example here still uses hctl create module \ without providing the module id/name. Earlier in the README you updated the create command to hctl create module score-workload \, which suggests the id is required; this example should be updated similarly (or changed to hctl update module ... if the intent is to modify an existing module).
hctl create module \
    ...
    --set=module_inputs='{"namespace": "my-namespace", "service_account_name": "my-sa", "wait_for_rollout": false}'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 10, 2026 13:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 13, 2026 16:51
@TobiasBabin TobiasBabin review requested due to automatic review settings February 13, 2026 16:51
Copilot AI review requested due to automatic review settings February 13, 2026 16:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

README.md:106

  • This CLI example uses hctl create module \ without providing the module id/name, but earlier in the README the install command uses hctl create module score-workload \. If hctl create module requires the module id, this example is not runnable as written; consider including the module id here as well (or clarify via the ... placeholder).
hctl create module \
    ...
    --set=module_inputs='{"namespace": "my-namespace", "service_account_name": "my-sa", "wait_for_rollout": false}'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 24, 2026 15:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 24, 2026 15:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TobiasBabin TobiasBabin merged commit 674fc9c into main Mar 25, 2026
7 checks passed
@TobiasBabin TobiasBabin deleted the add-tf-to-readme branch March 25, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants