Conversation
There was a problem hiding this comment.
Pull request overview
Updates the main README to include Terraform/OpenTofu (HCL) equivalents alongside existing hctl CLI examples for creating the score-workload resource type and installing/configuring the module.
Changes:
- Add Terraform/OpenTofu examples for creating the
score-workloadresource type. - Add Terraform/OpenTofu examples for creating the
score-workloadmodule and configuring inputs. - Expand the dynamic namespace section with Terraform/OpenTofu dependency + placeholder examples.
Comments suppressed due to low confidence (1)
README.md:106
- The CLI examples are inconsistent about whether the module id/name is passed as a positional argument. Earlier you use
hctl create module score-workload ..., but this later example showshctl create module \without specifying the module id. Make this consistent (either include the module id here too, or show the equivalent--set=id=...form if that’s the intended syntax).
hctl create module \
...
--set=module_inputs='{"namespace": "my-namespace", "service_account_name": "my-sa", "wait_for_rollout": false}'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
README.md:106
- The CLI example here still uses
hctl create module \without providing the module id/name. Earlier in the README you updated the create command tohctl create module score-workload \, which suggests the id is required; this example should be updated similarly (or changed tohctl update module ...if the intent is to modify an existing module).
hctl create module \
...
--set=module_inputs='{"namespace": "my-namespace", "service_account_name": "my-sa", "wait_for_rollout": false}'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
README.md:106
- This CLI example uses
hctl create module \without providing the module id/name, but earlier in the README the install command useshctl create module score-workload \. Ifhctl create modulerequires the module id, this example is not runnable as written; consider including the module id here as well (or clarify via the...placeholder).
hctl create module \
...
--set=module_inputs='{"namespace": "my-namespace", "service_account_name": "my-sa", "wait_for_rollout": false}'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR adds the Terraform/OpenTofu variants to the existing CLI commands for setting up the core resource type and module in the main README.
It also fixes an error in the
hctl create resource-type score-workloadcommand where an extra "'" rendered the command not functional.