Skip to content

chore: node24#51

Open
louisbennett wants to merge 4 commits intomainfrom
202603-cleanup
Open

chore: node24#51
louisbennett wants to merge 4 commits intomainfrom
202603-cleanup

Conversation

@louisbennett
Copy link
Copy Markdown
Contributor

Clean-up from #50, simplifying internal GHA and codifying support of node24+

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the Node 24+ baseline work from #50 by updating TypeScript configuration and GitHub Action runtime settings, and by simplifying the CI workflow configuration.

Changes:

  • Switch TypeScript base config from @tsconfig/node20 to @tsconfig/node24.
  • Update the action runtime to runs.using: node24.
  • Simplify CI by removing the Node matrix and adjusting the setup-node step.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsconfig.json Updates TS base config to the Node 24 preset.
package.json Replaces @tsconfig/node20 with @tsconfig/node24 dev dependency.
package-lock.json Locks @tsconfig/node24 and removes the node20 preset entry.
action.yaml Sets the GitHub Action runtime to node24.
.github/workflows/ci.yml Removes the matrix but now relies on an unpinned Node setup step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .github/workflows/ci.yml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the Node.js 24+ migration/cleanup after #50 by updating the TypeScript config baseline and the action runtime, and simplifying CI configuration.

Changes:

  • Switch TypeScript configuration from @tsconfig/node20 to @tsconfig/node24.
  • Update the GitHub Action runtime from node20 to node24.
  • Simplify CI workflow and update development documentation to reflect Node 24.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.json Move TS compiler defaults to Node 24 baseline.
package.json Replace Node 20 tsconfig dependency with Node 24.
package-lock.json Lockfile update reflecting @tsconfig/node24.
action.yaml Run the action using the Node 24 runtime.
README.md Document Node 24 requirement for development.
.github/workflows/ci.yml Simplify CI Node setup step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread package.json
Comment thread README.md Outdated
Comment thread .github/workflows/ci.yml
louisbennett and others added 3 commits March 19, 2026 16:51
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants