Add support for term meta data#106
Open
stephenharris wants to merge 2 commits intohumanmade:masterfrom
stephenharris:feature/term-meta2
Open
Add support for term meta data#106stephenharris wants to merge 2 commits intohumanmade:masterfrom stephenharris:feature/term-meta2
stephenharris wants to merge 2 commits intohumanmade:masterfrom
stephenharris:feature/term-meta2
Conversation
Author
|
If If that is indeed a bug then I'm happy to open another PR to fix that, and modify this one accordingly. |
rmccue
reviewed
Mar 8, 2017
| * | ||
| * @param array $meta_item Meta data. (Return empty to skip.) | ||
| * @param int $term_id Term the meta is attached to. | ||
| */ |
Member
There was a problem hiding this comment.
Continuing from #18 (comment)
I think the term_id is different to the term data, so we can't just pass term.
|
|
||
| // export gets meta straight from the DB so could have a serialized string | ||
| $value = maybe_unserialize( $meta_item['value'] ); | ||
|
|
Member
|
Agreed, I think it should be a |
… should skip the current term meta, not all subsequent term meta.
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress 4.4 adds term meta data, and trac ticket 34602, adds term meta data to the WXR export file. Although that ticket is still open, and is unlikely to be in 4.4, this PR adds support for importing term meta data, following the schema set out in that ticket.
This PR replaces #18