fix: remove empty returning() call on insert statement#42
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: remove empty returning() call on insert statement#42hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
insert(model).returning() was called with no arguments when self.returning is None. This produces an invalid statement. The returning() clause should only be added when returning columns are specified, consistent with the update branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insert(self.model).returning()was called with no arguments whenself.returningisNonereturning()clause is correctly applied later only whenself.returningis set, but the empty.returning()call on line 46 was always executed for insertsinsert(self.model)without the empty.returning(), consistent with theupdatebranchTest plan
🤖 Generated with Claude Code