fix: move _running_batches cleanup to finally block in _batch_run#45
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: move _running_batches cleanup to finally block in _batch_run#45hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
If set_exception or set_result raises (e.g., future already cancelled), the task_id was never removed from _running_batches, causing a leak. Moving the cleanup to a finally block ensures it always runs. Also use pop with default to avoid KeyError if task was already removed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_exceptionorset_resultraises (e.g., future already cancelled),task_idwas never removed from_running_batches, causing a memory leakpop+ debug log) into afinallyblock to ensure it always executespop(task_id, None)to avoidKeyErrorif the task was already removedTest plan
🤖 Generated with Claude Code