fix cpu fetching code for leopard and tiger#387
Merged
hykilpikonna merged 2 commits intohykilpikonna:masterfrom Feb 15, 2025
Un1q32:master
Merged
fix cpu fetching code for leopard and tiger#387hykilpikonna merged 2 commits intohykilpikonna:masterfrom Un1q32:master
hykilpikonna merged 2 commits intohykilpikonna:masterfrom
Un1q32:master
Conversation
hykilpikonna
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed CPU string fetching code, I'm not sure why it was setup to find the string "CPU Type", as neither Tiger or Leopard use that
Removed CPU Speed fetching code. It was also broken, looking for "CPU Speed" instead of "Processor Speed", and could be fixed, but fixing it would sometimes make it get a number with a decimal like 3.3 GHz, which broke some code later on that expected it to be an integer, so I figured it was better not to have it.
The cores bit did nothing, as it gets overwritten by the bit right below it that gets the number of cores with sysctl commands.
Additional context
Also removed the bit that removes Core from CPU info, as it turned my Intel Core 2 Duo into an Intel 2 Duo.