[FEATURE PROTOTYPE] adds step on interactive setup which prompts the user for either the default or small variant of their distro logo.#392
Merged
hykilpikonna merged 5 commits intohykilpikonna:masterfrom Apr 6, 2025
Conversation
…default or small variant of their distro logo.
hykilpikonna
approved these changes
Apr 6, 2025
Owner
|
That's honestly a great idea, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello !! hope you're doing well :3
this is the first time i have ever contributed code to an open-source project, so bare with me !!
Description
when i got hyfetch, i really wanted to use the smaller logo version of my distro (arch) for the fetch screen. however, it wasn't super obvious through the interactive setup that i had to manually specify the option by appending "arch_small" to the config under the distro setting afterward.
this pr adds an extra step on the interactive setup (after you specify your color preset and before changing color alignment). if a small logo version of your currently running distro exists, then it presents an extra option prompting the user to pick either the default logo or the small logo
Screenshots
quick note:
i couldn't figure out how to center the small logo horizontally with the large logo (i only figured out how to do it vertically), so i just added a bunch of spaces in the "line.join()" line as a remedy. the lack of horizontal centering has the side effect of looking a little weird when the terminal viewport can only show one logo per row. i am still learning rust (having a blast learning it !!), so if aspects of my code are a bit bad practice for rust please lmk !!