Skip to content

Temporary fix to GH-399#428

Merged
hykilpikonna merged 1 commit intohykilpikonna:masterfrom
Thundertides:master
Sep 7, 2025
Merged

Temporary fix to GH-399#428
hykilpikonna merged 1 commit intohykilpikonna:masterfrom
Thundertides:master

Conversation

@Thundertides
Copy link
Contributor

Description

This fixes the issue caused by get_distro_ascii() where it adds an extra line, I have temporary moved this line later on in the code as a patch.

Relevant Links

#399

Screenshots

Before:
image

After:
image

Additional context

I cant seem to figure out how get_distro_ascii() is called, besides maybe from neofetch directly, so it would be great if someone could point that out to me :>

@Thundertides
Copy link
Contributor Author

I forgot to note, I fixed this specifically in the python version only.

@hykilpikonna hykilpikonna merged commit 075fc46 into hykilpikonna:master Sep 7, 2025
1 check passed
@hykilpikonna
Copy link
Owner

Thanks!

@hykilpikonna
Copy link
Owner

I cant seem to figure out how get_distro_ascii() is called, besides maybe from neofetch directly, so it would be great if someone could point that out to me :>

Yea it's here:

def get_distro_ascii(distro: str | None = None) -> str:

I forgot to note, I fixed this specifically in the python version only.

that's perfect actually, the rust v2 doesn't have this problem so only python needs fixing anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants