Skip to content

Remove Toolz reimplementations#2042

Merged
Kodiologist merged 10 commits intohylang:masterfrom
Kodiologist:untoolz
Apr 23, 2021
Merged

Remove Toolz reimplementations#2042
Kodiologist merged 10 commits intohylang:masterfrom
Kodiologist:untoolz

Conversation

@Kodiologist
Copy link
Member

No description provided.

@allison-casey
Copy link
Contributor

if by2s is going to be imported into other modules, it should have a docstring imo. Otherwise looks good to me

@Kodiologist
Copy link
Member Author

Okay, I figured it didn't need one because it's only for internal use, but it's no trouble. Done.

@allison-casey
Copy link
Contributor

allison-casey commented Apr 21, 2021

doing the full autodoc args returns etc would be overkill, but it's good practice to have something for those methods.

@allison-casey allison-casey self-requested a review April 21, 2021 01:50
allison-casey
allison-casey previously approved these changes Apr 21, 2021
@allison-casey allison-casey dismissed their stale review April 21, 2021 01:52

didn't update docs conf.py to remove partition

@Kodiologist
Copy link
Member Author

Oops, you're right. I forgot to check the whole docs directory. This PR was a surprising amount of work.

@allison-casey
Copy link
Contributor

I can go through and fix the docs for you. by2s won't work since it doesn't support fillvalue and will drop the last entry if there's an odd number, but we can just use the itertools.grouper recipe for that

@Kodiologist
Copy link
Member Author

That would be convenient. Thanks.

@allison-casey
Copy link
Contributor

Docs are fixed for this and the itertools alias removals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants