fix(connect): strictly check resource when required. Strictly ensure destroy confirmation is true

.github/workflows/connect.yml

@@ -19,20 +19,21 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        deno-version: [1.x]
+        deno-version: [2.x]
 
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: 🦕 Setup Deno
-        uses: denoland/setup-deno@v1
+        uses: denoland/setup-deno@v2
         with:
           deno-version: ${{ matrix.deno-version }}
 
       - name: ⚡ Run Tests
         run: |
           cd packages/connect
+          deno install
           deno task test
         env:
           CI: true
@@ -41,20 +42,20 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
-        deno-version: [1.x]
+        node-version: [18.x, 20.x, 22.x]
+        deno-version: [2.x]
 
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: 🦕 Setup Deno
-        uses: denoland/setup-deno@v1
+        uses: denoland/setup-deno@v2
         with:
           deno-version: ${{ matrix.deno-version }}
 
       - name: ⎔ Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: "https://registry.npmjs.org"
@@ -75,10 +76,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: 🦕 Setup Deno
-        uses: denoland/setup-deno@v1
+        uses: denoland/setup-deno@v2
         with:
           deno-version: v1.x
 
@@ -99,17 +100,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: 🦕 Setup Deno
-        uses: denoland/setup-deno@v1
+        uses: denoland/setup-deno@v2
         with:
           deno-version: 1.x
 
       - name: ⎔ Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version:  18.x
+          node-version:  22.x
           registry-url: "https://registry.npmjs.org"
 
       - name: 🦠 Publish to NPM

.github/workflows/tag-and-release.yml

@@ -23,16 +23,16 @@ jobs:
     steps:
 
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           # Allows for pushes from this workflow to trigger subsequent workflows 
           token: ${{ secrets.CI_GITHUB_TOKEN }}
           fetch-depth: 0
 
       - name: ⎔ Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 22.x
 
       - name: 🤓 Set Git User
         run: |

packages/connect/Makefile

@@ -6,7 +6,7 @@ clean:
 # to copy the types from the output of deno2node into the microbundle output folder in order to get types working
 # a total hack to get the types working
 to-node:
-	@deno run --no-check --allow-read --allow-write \
+	@deno run --no-check --allow-read --allow-write --allow-env --allow-import \
   		https://deno.land/x/[email protected]/src/cli.ts ./tsconfig.to-node.jsonc && \
 	yarn build && \
 	echo "copying types..." && find ./to-node -mindepth 1 -depth -name '*.d.ts' -exec cp --parents \{\} ./dist \; && \

packages/connect/deno.json

@@ -1,7 +1,7 @@
 {
   "tasks": {
-    "cache": "deno cache --lock=deno.lock --lock-write deno/deps.deno.ts deno/dev_deps.ts",
-    "test": "deno lint && deno fmt && deno test -A --no-lock deno/tests",
+    "cache": "deno cache --lock=deno.lock -A deno/deps.deno.ts deno/dev_deps.ts",
+    "test": "deno lint && deno fmt && deno test -A --no-lock --no-check deno/tests",
     "test:integration": "make test-integration",
     "to-node": "make clean to-node"
   },
@@ -27,8 +27,7 @@
       "./to-node",
       "node_modules/",
       "node/node_modules",
-      "node/harness/cjs/node_modules",
-      "node/harness/esm/node_modules",
+      "node/harness",
       "./yarn.lock"
     ]
   }