Skip to content

If prost allows empty packages, tonic generates wrong endpoints #381

@tylerhawkes

Description

@tylerhawkes

Bug Report

Version

0.2.1

Platform

Linux 5.5.11-200.fc31.x86_64 #1 SMP Mon Mar 23 17:32:43 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Crates

tonic-build

Description

I have a fork of prost at https://github.com/vivint-smarthome/prost/tree/prost-no-package that allows for packages to not be specified because we really want to use tonic/prost but we have pre-defined protos without a package and adding a package is a breaking change for grpc. Tonic-build generates endpoints that begin with /.<ServiceName>/<MethodName> which is incorrect. The correct output should be /<ServiceName>/<MethodName>.

I'll submit a pull request to fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-buildC-bugCategory: Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions