Merged
Conversation
LucioFranco
reviewed
Nov 9, 2022
Comment on lines
+230
to
+208
| format!( | ||
| "{}{}{}.{}", | ||
| package, | ||
| if package.is_empty() { "" } else { "." }, | ||
| service.identifier(), | ||
| method.identifier() | ||
| ) |
Member
There was a problem hiding this comment.
I was thinking just this code could be put into a fn the rest I think we could leave
Contributor
Author
There was a problem hiding this comment.
Is it like this? Should I not move format_method_name to the lib?
d0c90a4
bouzuya
force-pushed
the
follow-up-1127
branch
from
66e7142 to
de45dd4
Compare
LucioFranco
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #1127 (comment)
@LucioFranco
I didn't understand how to centralize the impls, so I would like you to comment on the draft PRs.